Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard coded surefire config #199

Merged
merged 1 commit into from Aug 9, 2023
Merged

Remove hard coded surefire config #199

merged 1 commit into from Aug 9, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Aug 9, 2023 •
edited

the hard coded surefire config means it can not be overridden in CI or the CLI.

Whilst forkCount is the most pressing - if unlimited threads really are used, that would seem like an issue for people on slow computers, or VMs with not a lot of CPU.

amends: #198

Testing done

checked https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fcopyartifact-plugin/detail/PR-199/1/pipeline/70#step-88-log-892 is still running multiple tests in parallel

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@jtnord
remove hard coded surefire config
d8e74da 
the hard coded surefire config means it can not be overridden in CI or the CLI.

Whilst forkCount is the most pressing - if unlimited threads really are used, that would seem like an issue for people on slow computers, or VMs with not a lot of CPU.
@jtnord jtnord requested a review from a team as a code owner August 9, 2023 12:32
MarkEWaite
MarkEWaite approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) August 9, 2023 13:14
@MarkEWaite MarkEWaite added the test label Aug 9, 2023
@MarkEWaite MarkEWaite changed the title remove hard coded surefire config Remove hard coded surefire config Aug 9, 2023
@MarkEWaite MarkEWaite merged commit 3a6e680 into jenkinsci:master Aug 9, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
2 participants
@jtnord @MarkEWaite