Update dependencies and stabilize tests #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Aug 23, 2023
pom.xml
Outdated
| <useBeta>true</useBeta> | ||
| <spotbugs.effort>Max</spotbugs.effort> | ||
| <spotbugs.threshold>Low</spotbugs.threshold> | ||
| <!-- TODO pending inclusion in parent: --> | ||
| <jenkins-test-harness.version>2061.v04b_f07857801</jenkins-test-harness.version> <!-- TODO https://github.com/jenkinsci/jenkins-test-harness/pull/643 --> |
There was a problem hiding this comment.
Comment on lines
337
to
338
| FreeStyleBuild b = p.scheduleBuild2(0, new Cause.UserIdCause()).get(); | ||
| rule.assertBuildStatusSuccess(b); |
There was a problem hiding this comment.
Leaving more complex multiline idioms for proper tooling: openrewrite/rewrite-jenkins#43
jglick
commented
Aug 23, 2023
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <systemPropertyVariables> | ||
| <org.jvnet.hudson.test.RemainingActivityListener.wait>true</org.jvnet.hudson.test.RemainingActivityListener.wait> |
There was a problem hiding this comment.
Example:
=== Starting testWithPermalinkBuildSelector(hudson.plugins.copyartifact.LastCompletedBuildSelectorTest)
0.008 [id=102] INFO o.jvnet.hudson.test.JenkinsRule#createWebServer: Running on http://localhost:40519/jenkins/
0.090 [id=115] INFO jenkins.InitReactorRunner$1#onAttained: Started initialization
0.092 [id=132] INFO jenkins.InitReactorRunner$1#onAttained: Listed all plugins
0.093 [id=116] INFO j.b.api.BouncyCastlePlugin#start: …/plugins/bouncycastle-api/WEB-INF/optional-lib not found; for non RealJenkinsRule this is fine and can be ignored.
0.321 [id=123] INFO jenkins.InitReactorRunner$1#onAttained: Prepared all plugins
0.324 [id=136] INFO jenkins.InitReactorRunner$1#onAttained: Started all plugins
0.324 [id=118] INFO jenkins.InitReactorRunner$1#onAttained: Augmented all extensions
0.326 [id=136] INFO h.p.c.CopyArtifactConfiguration#load: CopyArtifact is set to Production mode.
0.860 [id=125] INFO jenkins.InitReactorRunner$1#onAttained: System config loaded
0.860 [id=121] INFO jenkins.InitReactorRunner$1#onAttained: System config adapted
0.873 [id=126] INFO jenkins.InitReactorRunner$1#onAttained: Loaded all jobs
0.874 [id=126] INFO jenkins.InitReactorRunner$1#onAttained: Configuration for all jobs updated
0.887 [id=127] INFO jenkins.InitReactorRunner$1#onAttained: Completed initialization
1.900 [id=153] INFO hudson.model.Run#execute: test0 #2 aborted
java.lang.InterruptedException: sleep interrupted
at java.base/java.lang.Thread.sleep(Native Method)
at org.jvnet.hudson.test.SleepBuilder.perform(SleepBuilder.java:51)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:818)
at hudson.model.Build$BuildExecution.build(Build.java:199)
at hudson.model.Build$BuildExecution.doRun(Build.java:164)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:526)
at hudson.model.Run.execute(Run.java:1900)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:44)
at hudson.model.ResourceController.execute(ResourceController.java:101)
at hudson.model.Executor.run(Executor.java:442)
1.901 [id=102] WARNING o.j.h.t.RemainingActivityListener#onTearDown: test0 #2 still seems to be running, which could break deletion of log files or metadata
6.904 [id=102] INFO hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
6.920 [id=102] INFO hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
7.011 [id=102] INFO o.j.h.t.TemporaryDirectoryAllocator#dispose: deleting …
pointing to
|
Is |
|
Until someone finds the time to go through the tests in this plugin and clean them up. |
|
Mmm, "someone." |
|
I would personally not have approved this PR. |
basil
reviewed
Apr 1, 2024
Comment on lines
+35
to
+36
| <!-- TODO pending inclusion in parent: --> | ||
| <jenkins-test-harness.version>2062.v3efc79721e45</jenkins-test-harness.version> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #203 & #205, trying to stabilize the test suite here which is apparently loaded with cases of background activity of unclear timing.