Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing JENKINS-16847 MultiJob Support #49

Closed
wants to merge 1 commit into from

Conversation

rsennewald
Copy link

-Added a new Build Selector called MultiJobBuildSelector.
-If selected, this will make the Copy Artifact Plugin look
for an artifact from that job's build which was part of the
current MultiJobBuild.
-This selector will work properly if you configure it with
a MultiJobProject which has a PhaseJob that archives an
artifact that you want to retrieve as part of the MultiJob.
-This selector will also work if you configure it to Copy an
Artifact from another Phase Job which was part of the
current MultiJob Build.
-Added tests to ensure this functionality works as expected.
-Adds MultiJob Plugin as a dependency.

-Added a new Build Selector called MultiJobBuildSelector.
-If selected, this will make the Copy Artifact Plugin look
for an artifact from that job's build which was part of the
current MultiJobBuild.
-This selector will work properly if you configure it with
a MultiJobProject which has a PhaseJob that archives an
artifact that you want to retrieve as part of the MultiJob.
-This selector will also work if you configure it to Copy an
Artifact from another Phase Job which was part of the
current MultiJob Build.
-Added tests to ensure this functionality works as expected.
-Adds MultiJob Plugin as a dependency.
return true;
}

@Extension(ordinal=20)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not optional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean not optional? What specifically?

@daniel-beck
Copy link
Member

Why not add this to MultiJob? Copy Artifacts has three times the installations after all, so that seems to be a more logical place to store the integration (I expect a higher percentage of MultiJob users have Copy Artifact than vice versa).

@rsennewald
Copy link
Author

This functionality could be added to MultiJob I suppose, I didn't think about that. I could make it part of the Phase Job Configuration piece to grab an artifact from another Phase Job and then add an option to Copy an Artifact from Phase Job as a Build step for the MultiJob as well. Is this what you were thinking?

@daniel-beck
Copy link
Member

No, you should be able to add an optional dependency from MJ to CA, and just move your new Build Selector there. Would appear the same to users, but implemented in MJ.

@rsennewald
Copy link
Author

@daniel-beck Thank you for your recommendation. After some thought and consideration I will be moving this to the MultiJob Plugin and add the Copy Artifact Plugin as an Optional Dependency there. Then, only if you have both installed, you'll get my newly added option as I would prefer it to be anyway.

@rsennewald rsennewald closed this Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants