[JENKINS-33578] DownstreamBuildSelector is not applicable to Workflow jobs. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treamBuildSelector to Workflow jobs.
| @@ -90,6 +90,7 @@ public String getUpstreamBuildNumber() { | |||
| @Override | |||
| protected boolean isSelectable(Run<?, ?> run, EnvVars env) { | |||
| if (!(run instanceof AbstractBuild<?,?>)) { | |||
| // As this feature depends on `AbstractBuild#getUpstreamRelationshipBuild(AbstractProject<?,?>)` | |||
| LOGGER.warning(String.format("Only applicable to AbstractBuild: but is %s.", run.getClass().getName())); | |||
There was a problem hiding this comment.
This can never be warned at the configuration time...
…for DownstreamBuildSelector. Workflow projects continue to be listed as allow to complete folder names.
…tProject for DownstreamBuildSelector.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-33578
Though the issue described in the ticket is fixed in #79, I found
DownstreamBuildSelectoris not applicable to Workflow jobs as it depends onAbstractBuild#getUpstreamRelationshipBuild.This change show error or warnings messages to users when they tries to use
DownstreamBuildSelectorwithWorkflow.