Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72448] Make sure that logging statements are in correct order #47

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Dec 21, 2023

Use a unique log handler so that all logging statements are shown only once and in the correct order. Also make sure that all log statements are persisted, otherwise the view "coverage/info" shows only a part of the log.

Note: codingstyle v3.31.0 is required as well to correctly show merged error messages in the correct order.

Use a unique log handler so that all logging statements are shown
only once and in the correct order. Also make sure that all log
statements are persisted, otherwise the view "coverage/info" shows
only a part of the log.
@uhafner uhafner added the bug Bugs or performance problems label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7a14a23) 76.56% compared to head (b36eaa8) 76.56%.

Files Patch % Lines
...ugins/coverage/metrics/steps/CoverageReporter.java 95.34% 1 Missing and 1 partial ⚠️
...gins/coverage/metrics/steps/CoverageViewModel.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main      #47   +/-   ##
=========================================
  Coverage     76.56%   76.56%           
- Complexity      737      741    +4     
=========================================
  Files            47       47           
  Lines          2628     2633    +5     
  Branches        255      254    -1     
=========================================
+ Hits           2012     2016    +4     
- Misses          532      533    +1     
  Partials         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 2236038 into main Dec 22, 2023
30 checks passed
@uhafner uhafner deleted the single-logger branch December 22, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
1 participant