Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-18109] Show all violations highlighted on a single page #14

Merged
merged 1 commit into from Apr 29, 2014

Conversation

mixalturek
Copy link
Contributor

  • New URL ".../cppcheckResult/source.all" points to a dynamic page rendered using a newly implemented class CppcheckSourceAll. Optional parameters are before=NUM and after=NUM to specify number of displayed lines, their default value is 5. A link was added above the table on the details page.
  • Variable cppcheckfile refactored to cppcheckFile (f/F) to prevent copy-paste errors.
  • Null check for return value of diffCurrentAndPrevious() removed, the method never returns null (found by FindBugs).
  • Source details show only part of the path relative to the workspace in the header instead of the very long absolute path, the method getFileNameHtmlWrap() removed.
  • Cppcheck message must be HTML escaped before passing to the page (e.g. "Comparison of a variable having boolean value using relational (<, >, <= or >=) operator.").
  • Missing space added to the tooltip on the page with source code of a whole file.
  • Annotations added to deprecated members present for backward compatibility.

- New URL ".../cppcheckResult/source.all" points to a dynamic page rendered using a newly implemented class CppcheckSourceAll. Optional parameters are before=NUM and after=NUM to specify number of displayed lines, their default value is 5. A link was added above the table on the details page.
- Variable cppcheckfile refactored to cppcheckFile (f/F) to prevent copy-paste errors.
- Null check for return value of diffCurrentAndPrevious() removed, the method never returns null (found by FindBugs).
- Source details show only part of the path relative to the workspace in the header instead of the very long absolute path, the method getFileNameHtmlWrap() removed.
- Cppcheck message must be HTML escaped before passing to the page (e.g. "Comparison of a variable having boolean value using relational (<, >, <= or >=) operator.").
- Missing space added to the tooltip on the page with source code of a whole file.
- Annotations added to deprecated members present for backward compatibility.
@cloudbees-pull-request-builder

plugins » cppcheck-plugin #41 SUCCESS
This pull request looks good

mixalturek added a commit that referenced this pull request Apr 29, 2014
[JENKINS-18109] Show all violations highlighted on a single page
@mixalturek mixalturek merged commit cf2d85a into jenkinsci:master Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants