jep-227 downstream usage #280

Vlatombe · 2023-10-26T06:47:20Z

Downstream of [JEP-227][JENKINS-39324] Replace Acegi Security with Spring Security APIs credentials-plugin#490

Testing done

Submitter checklist

Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

jglick · 2023-10-27T12:11:15Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/BindingDescriptor.java

@@ -60,7 +60,7 @@ public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item owner) {
        // when configuring the job, you only want those credentials that are available to ACL.SYSTEM selectable
        // as we cannot select from a user's credentials unless they are the only user submitting the build
        // (which we cannot assume) thus ACL.SYSTEM is correct here.
-        return new Model().withAll(CredentialsProvider.lookupCredentials(type(), owner, ACL.SYSTEM, Collections.emptyList()));
+        return new Model().withAll(CredentialsProvider.lookupCredentialsInItem(type(), owner, ACL.SYSTEM2, Collections.emptyList()));


or we can use List.of()

pom.xml

Downstream usage of new jep-227 APIs

11e87d1

Vlatombe mentioned this pull request Oct 26, 2023

[JEP-227][JENKINS-39324] Replace Acegi Security with Spring Security APIs jenkinsci/credentials-plugin#490

Merged

Vlatombe changed the title ~~Downstream usage of new jep-227 APIs~~ jep-227 downstream usage Oct 26, 2023

jglick approved these changes Oct 27, 2023

View reviewed changes

jglick reviewed Nov 1, 2023

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

Pick up release

058e749

jglick marked this pull request as ready for review November 1, 2023 21:19

jglick requested a review from a team as a code owner November 1, 2023 21:19

jglick added the dependencies label Nov 1, 2023

jglick enabled auto-merge November 1, 2023 21:19

jglick merged commit f929416 into jenkinsci:master Nov 1, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jep-227 downstream usage #280

jep-227 downstream usage #280

Vlatombe commented Oct 26, 2023 •

edited by jglick

Submitter checklist

jglick Oct 27, 2023

jep-227 downstream usage #280

jep-227 downstream usage #280

Conversation

Vlatombe commented Oct 26, 2023 • edited by jglick

Testing done

Submitter checklist

jglick Oct 27, 2023

Choose a reason for hiding this comment

Vlatombe commented Oct 26, 2023 •

edited by jglick