Make userId transient

Signed-off-by: Matt Sicker <boards@gmail.com>
jenkinsci · Jul 23, 2019 · a3098b5 · a3098b5
1 parent 6e9b44f
commit a3098b5
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/main/java/com/cloudbees/plugins/credentials/CredentialsParameterValue.java b/src/main/java/com/cloudbees/plugins/credentials/CredentialsParameterValue.java
@@ -4,6 +4,7 @@
 import com.cloudbees.plugins.credentials.common.StandardCredentials;
 import com.cloudbees.plugins.credentials.domains.Domain;
 import com.cloudbees.plugins.credentials.domains.DomainRequirement;
+import edu.umd.cs.findbugs.annotations.CheckForNull;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.EnvVars;
 import hudson.Util;
@@ -45,7 +46,7 @@ public class CredentialsParameterValue extends ParameterValue {
     /**
      * The user who supplied the parameter value.
      */
-    private String userId;
+    private transient final String userId;
 
     @DataBoundConstructor
     public CredentialsParameterValue(String name, String value, String description) {
@@ -63,20 +64,14 @@ public CredentialsParameterValue(String name, String value, String description,
         this.userId = userId;
     }
 
-    private Object readResolve() {
-        if (userId == null) {
-            userId = Jenkins.getAuthentication().getName();
-        }
-        return this;
-    }
-
     public String getValue() {
         return value;
     }
 
     /**
      * Returns the user id of who filled in this credentials parameter.
      */
+    @CheckForNull
     String getUserId() {
         return userId;
     }