Add config as code support for credentials configuration #235
Conversation
| .map(type -> type.getClass().getName()) | ||
| .filter(classNames::contains) | ||
| .collect(Collectors.toList()); | ||
| return new ArrayList<>(classNames); |
There was a problem hiding this comment.
I couldn't find any references to this method anywhere so I don't know how to test if this works or not, all tests in this plugin pass.
There was a problem hiding this comment.
I've checked and the functionality for includes and excludes still works:
There was a problem hiding this comment.
💡 What you tested in your screenshot is the CredentialsProviderFilter.
For CredentialsTypeFilter it's the Types > Add > Includes / Excludes.
Manually tested, it still works 👍 (at least, not discovered flaw)
(the last one, Restrictions, is covered by CredentialsProviderTypeRestriction)
| .map(type -> type.getClass().getName()) | ||
| .filter(classNames::contains) | ||
| .collect(Collectors.toList()); | ||
| return new ArrayList<>(classNames); |
There was a problem hiding this comment.
👍
With the assertion in mind that the classNames is coming from the UI ("positive" story), that list is populated from getProviderDescriptors which corresponds. No negative story found as the filter method only receive a CredentialsProvider, so no cheat possible.
Only "cons" is if some providers are removed over time, the existing configuration will still have a Set with them inside, no impact.
| .map(type -> type.getClass().getName()) | ||
| .filter(classNames::contains) | ||
| .collect(Collectors.toList()); | ||
| return new ArrayList<>(classNames); |
There was a problem hiding this comment.
💡 What you tested in your screenshot is the CredentialsProviderFilter.
For CredentialsTypeFilter it's the Types > Add > Includes / Excludes.
Manually tested, it still works 👍 (at least, not discovered flaw)
(the last one, Restrictions, is covered by CredentialsProviderTypeRestriction)
Propogating through atm, will merge and release bom and update bom, if you're in no rush I'd hold off |
Doing some reviews/merge today, if not done today, will come back on it soon-ish after ;) |
src/test/resources/com/cloudbees/plugins/credentials/casc/credentialsProviderManager.yaml
Outdated
Show resolved
Hide resolved
src/test/java/com/cloudbees/plugins/credentials/CredentialsProviderTypeRestrictionTest.java
Show resolved
Hide resolved
|
@Wadeck reminder |
|
Possibly caused: https://issues.jenkins.io/browse/JENKINS-67170 |
some minor jcasc testing cleanup done as well
Fixes jenkinsci/azure-keyvault-plugin#92