Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-69653] Un-inlining dialog.jelly #378

Merged
merged 1 commit into from Nov 9, 2022
Merged

[JENKINS-69653] Un-inlining dialog.jelly #378

merged 1 commit into from Nov 9, 2022

Conversation

Pldi23
Copy link
Contributor

@Pldi23 Pldi23 commented Oct 12, 2022 •
edited

Hello,

Hacktoberfesting to solve JENKINS-69653.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Manually test to ensure 'Cancel' and 'Add' buttons works as before:

Screen.Recording.2022-10-18.at.13.52.47.mov

@Pldi23 Pldi23 force-pushed the JENKINS-69653_csp_hacktoberfest branch from 714024c to feeefe0 Compare October 12, 2022 08:17
@Pldi23
Copy link
Contributor Author

Pldi23 commented Oct 12, 2022

@Wadeck @daniel-beck (can't add reviewers, so mentioning you here)

@jtnord jtnord requested a review from a team October 24, 2022 10:20
Wadeck
Wadeck approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dima for the update and the video showing your testing 👍

@jtnord jtnord added the chore label Nov 9, 2022
@jtnord jtnord merged commit b656172 into jenkinsci:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wadeck Wadeck Wadeck approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
3 participants
@Pldi23 @Wadeck @jtnord