[JENKINS-69379] Removed obsolete styling in the Add button

[julieheard]

https://issues.jenkins.io/browse/JENKINS-69379

I have set this to be a draft pull request as I wanted to discuss if this is the correct approach for this fix.

When investigating the black line on the add button issue, I noticed that the other 'Add' buttons on the page didn't include 'jenkins-button' on them.

Example of a non-problematic add button on the same page:

I removed the 'jenkins-button' bits from the jelly file and tested, and now all of the buttons are looking consistent. Manual testing done with problem button:

Do you think this is the right approach? Is there something I am missing about removing the 'jenkins-button' bits from the button?

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[janfaracik]

Will take a look - thanks!

Looks good to me. Jenkins will hopefully be updated soon to remove the last of the YUI button JS/stylings, once that's done we can update this plugin to restore the .jenkins-button class.

Could you also remove the line button.credentials-add-menu { padding:0 20px 0 10px; } (but keep the class on the button) as its causing unnecessary padding on that button?

[julieheard]

Thank you @janfaracik for your comment. I have removed the padding now, if you are happy, I will change from a draft 🙂

[NotMyFault]

Thanks!