-
Notifications
You must be signed in to change notification settings - Fork 16
Fix NavBar item to Community Configurations #110
Conversation
The tests appear to fail during Windows testing. Different OSes have different line terminations (to the despair of programmers). Check your code for how the comparison is done and how the files are loaded. I see a call to |
@martinda I searched on Google but cannot seem to find any other method to read. Is there something I am missing.should I just include or exclude new lines from the test files . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the tests are fixed, this change can go through. You could submit a separate PR to fix the tests. I do not know why the tests would pass before, I am not sure it's even worth investigating. At this point we just want to fix them.
Ok, so I don't want this PR to be merged until the tests are passing. We don't want to corrupt the master branch.
@martinda should I close and reopen that will kickstart the build again maybe it will pass since it was passing before |
I think there is an issue with calling |
@martinda yeah I guess it does not matter since the previous builds were passing let's retrigger and check |
I had thought that the tests at one point were only supposed to be run on Linux? |
* Fix Navbar item * Update Header.js
* Fix Navbar item * Update Header.js
No description provided.