Add appropriate message if empty bundle

[sladyn98]

This PR fixes the app crashing if the bundle in the local cache is empty and instead adds an appropriate message.

[martinda]

Looks good but there might be an issue. See the comments.

[martinda]

So I am not sure how to test the changes in this PR. Can you explain the steps to manually test this?

[martinda]

What do you expect the user to do under this condition?

[sladyn98]

The user cannot do anything. He cannot manually change the title unless he goes back and creates a new configuration

[sladyn98]

To test manually you need to have npm and mavnen installed
To start Front-end:

cd frontend/
npm start

To start backend

mvn spring-boot:run

[kwhetstone]

I think there needs to be some extra logging or at least messaging for the else case.

I think you can add a whole separate ticket for testing.

[kwhetstone]

Should you also notes if there are issues if "bundle" isn't in the packageConfigJSON?

[sladyn98]

Should I add another condition to check if the bundle is present ?

[kwhetstone]

Only if there's not a check earlier for if JSON.parse(localStorage.getItem("packageConfigJSON"))["bundle"] is missing. If it's missing, then you can't do generation, but you should put something out to the console so you can trace where a problem happened.

[sladyn98]

These are just for the description for the cards so we do not really care if it present or not. If the generation errors out the backend comes back with the 404.

[martinda]

I am having difficulties running this PR. I get these errors in the frontend:

Proxy error: Could not proxy request /favicon.ico from localhost:3000 to http://app-server:8080.
Proxy error: Could not proxy request /api/plugin/getPluginList from localhost:3000 to http://app-server:8080.

[sladyn98]

@kwhetstone @martinda Should we add more checks to this PR or is it good to go as is ?

[martinda]

Hi @sladyn98 . I still get the errors I mentioned above. Those need to be addressed. This PR is behind master, so I suggest you start by rebasing it on master. Then write down the steps to test all aspects of this fix, then write a unit test.

[sladyn98]

Steps to test this PR:
a) Select plugins and generate a package.
b) Verify if the selected package name appears on the package generation page.
c) If no package is generated or the editor is empty verify the above messages appear
1) Title: No title specified
2) Description: No Description specified

[sladyn98]

Then write down the steps to test all aspects of this fix, then write a unit test.

For the testing of react we would need to choose a tool and then setup the architecture for it
https://reactjs.org/docs/testing.html#:~:text=There%20are%20a%20few%20ways,to%2Dend%E2%80%9D%20tests).

[sladyn98]

Tested this with three different cases
a) Generating a package
b) Putting my own package
c) Blank page
And it works just fine

[martinda]

I get the infinite spinning wheel :-(

How I run it:

git fetch upstream refs/pull/119/head:refs/remotes/upstream/pull/119
git checkout pull/119
mvn clean
mvn spring-boot:run

In another terminal:

cd frontend
npm install && npm start

The errors:

Proxy error: Could not proxy request /favicon.ico from localhost:3000 to http://app-server:8080.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ENOTFOUND).

Proxy error: Could not proxy request /api/plugin/getPluginList from localhost:3000 to http://app-server:8080.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ENOTFOUND).

Proxy error: Could not proxy request /favicon.ico from localhost:3000 to http://app-server:8080.
See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ENOTFOUND).

[sladyn98]

@martinda you can only run this pr using docker since multiple environments is not yet supported.we need to merge that first to get this working using npm and spring Boot

[martinda]

Ok, so with docker "it runs" but I am still clueless with regards to testing this. What sequence of buttons should I click in the app? Should I expect error messages in the browser?

[sladyn98]

Steps to test this PR:
a) Select plugins and generate a package.
b) Verify if the package name appears on the package generation page.
c) If no package is generated or the editor is empty verify the above messages appear

1. Title: No title specified
2. Description: No Description specified

@martinda instructions are the same as the previous comment made a few days back. Should I add something more in the instructions?