Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Add a single page router that will redirect all missing requests to index.html #163

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Sep 7, 2020

Tested a bit locally. Seems to work

Created a test to confirm the redirect happens

@halkeye halkeye requested a review from a team as a code owner September 7, 2020 21:53
@halkeye
Copy link
Member Author

halkeye commented Sep 7, 2020

Demo: https://customize.jenkins-infra.g4v.dev/
/ doesn't do anything really, but all the other urls work it seems even after a refresh

Problem #1) API_URL was causing //api which isn't a valid api call
Problem #2) On refresh springboot would return 404 for the urls, adding the new wildcard match brings it back to index.html

Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @halkeye

@sladyn98 sladyn98 merged commit 4e44689 into jenkinsci:master Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants