This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Updates to frontend #169
Merged
Updates to frontend #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started with just adding more eslint rules and cleaning up undefined variables
* Removed localstorage and moved to a state object inside of Root App
* Added redirect for initial landing page
* Replaced a few components with functional components (mostly because
component did mount wasn't firing)
* Worked towards a single shared card layout screen (Only plugin is
using it so far)
sladyn98
approved these changes
Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with just adding more eslint rules and cleaning up undefined variables
component did mount wasn't firing)
using it so far)
Demo: https://customize.jenkins-infra.g4v.dev