-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
I will add new lines at the end of the files if required :) |
ARG JAR_FILE=target/custom-distribution-service-0.0.1.jar | ||
|
||
# Add the application's jar to the container | ||
ADD ${JAR_FILE} custom-distribution-service.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Use COPY instead of ADD for files and folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing these files together, do you want to put together a docker-compose? Adding directions to the README will help too.
@kwhetstone Yeah my initial aim was to get a docker compose file but the front end service throws a ton of errors when run using a docker compose, I will instead add instructions to the readme just so that we can run these separately. |
You can find some reasons for it from here. |
Commands for running the front end are, these should be run from the front-end directory Could you just try this on your local machine and see if it running because it is throwing me a bunch of errors @LinuxSuRen |
I can run it by the following command: But I'm not sure it can really work. |
@LinuxSuRen the command is failing on my machine I mean the docker container is still not running |
I generated the package-lock.json again @kwhetstone in order to make this run. I also removed the eslint scripts. I guess we can just add them later |
I think the big thing for this was to use eslint 6 instead of 7 since it was causing issues. I know they're different, and eslint 6 will be supported for a bit here since there's so much built on it. |
0b7f211
to
82d4f24
Compare
This file now only contains the dockerfile update, and the eslint version has been fixed in another PR here it is #37 . So kindly merge that before this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in.
@kwhetstone Roger that 🚀 |
Added simple dockerfile for frontend and backend to be able to run the project easily.