This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Connect plugin api with frontend #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sladyn98
added
backend
kwhetstone
reviewed
Jun 18, 2020
There was a problem hiding this comment.
Have you poked around https://github.com/jenkins-infra/plugin-site ? There's pagination there that can probably be copied. Returning all the plugins ever is going to take awhile. I figured that a lot of this application could mirror the pagination and filtering done by that project.
kwhetstone
approved these changes
Jun 23, 2020
|
@kwhetstone I have to maybe restrict the plugins to 50 maybe so that I can test it out. |
added 2 commits
June 24, 2020 13:39
kwhetstone
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects the plugin api with the front end to load the plugin cards dynamically.
I have not included the description inside it because some of the descriptions has some href links which were not rendered properly. Another issue is that the plugin api takes
48 secondsto come back with a response which is a bit concerning. Also the entire plugin list of 1600 plugins is displayed on a single screen which I guess is not right and we need to implement scrolling.