Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Add package-config generation frontend #55

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented Jun 19, 2020

This PR aims to add the front-end capabilities to generate the packager-config.yml.
Some decisions I took regarding the plugin storage.
a) I decided to make use of the local storage to store the plugins json array so that we can access it throughout the session, I wanted to make use of cookies but having a too large cookie would slow down performance so the Mozilla docs suggested going with local storage is fine .
b) Also I decided to not go with the props callback function method to pass data from child to parent instead went with the basic onClick={() => this.clickChild() methods, because we were not really passing data from child to parent instead just let the child component in this case pluginCards.js make the saving call to the localStorage API.

Another descision I had to make was make use of a modal while dispaying the form required for user data, I wanted to initally go for a separate page, but since this action was anyway going to be invoked on user action and would be only accessible by this page, I realised that a modal would be a good choice. Since I was working with react-strap using a modal became quite easy
Screenshot from 2020-06-22 17-49-00

@sladyn98 sladyn98 added feature A PR that adds a feature frontend Related to the front-end of the service labels Jun 19, 2020
@sladyn98 sladyn98 added this to the [GSoC Phase 1] milestone Jun 19, 2020
@sladyn98 sladyn98 requested a review from a team as a code owner June 19, 2020 13:27
@sladyn98 sladyn98 linked an issue Jun 19, 2020 that may be closed by this pull request
2 tasks
Copy link
Contributor

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the modal window, and you can get some extra feedback at the stage 1 demo next week. There could potentially be a lot of scrolling regardless of the option chosen which might be the thing people dislike the most.

@sladyn98 sladyn98 merged commit 41fe1c5 into jenkinsci:master Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A PR that adds a feature frontend Related to the front-end of the service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to add plugins to the custom configuration
2 participants