This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the front-end capabilities to generate the
packager-config.yml
.Some decisions I took regarding the plugin storage.
a) I decided to make use of the local storage to store the plugins json array so that we can access it throughout the session, I wanted to make use of cookies but having a too large cookie would slow down performance so the Mozilla docs suggested going with local storage is fine .
b) Also I decided to not go with the props callback function method to pass data from child to parent instead went with the basic
onClick={() => this.clickChild()
methods, because we were not really passing data from child to parent instead just let the child component in this casepluginCards.js
make the saving call to the localStorage API.Another descision I had to make was make use of a modal while dispaying the form required for user data, I wanted to initally go for a separate page, but since this action was anyway going to be invoked on user action and would be only accessible by this page, I realised that a modal would be a good choice. Since I was working with react-strap using a modal became quite easy