Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Remove test failure warnings #67

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Remove test failure warnings #67

merged 2 commits into from
Jul 14, 2020

Conversation

sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented Jul 8, 2020

This PR removes the ignorance on test failure boolean

@sladyn98 sladyn98 requested a review from a team as a code owner July 8, 2020 05:40
@martinda
Copy link
Contributor

martinda commented Jul 8, 2020

Please shortly explain why removing the test failure warnings is needed.

@martinda
Copy link
Contributor

martinda commented Jul 9, 2020

Oh I see, this was discussed at the meeting with mentors.

kwhetstone
kwhetstone approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right, it looks like the build failure is related to a timeout connection to the node. (end of file while connecting to EC2) I'd try restarting the build in order to see if it was a blip while this ran the first time.

@sladyn98 sladyn98 merged commit fbee033 into jenkinsci:master Jul 14, 2020
@sladyn98 sladyn98 added the test A PR that adds to testing - used by Release Drafter label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwhetstone kwhetstone kwhetstone approved these changes

Assignees
No one assigned
Labels
test A PR that adds to testing - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sladyn98 @martinda @kwhetstone