This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Fix docker file #79
Merged
Fix docker file #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good step forward to me. It does not fix everything. I still do not understand why I get nothing at http://localhost:8080 when I run the frontend and the backend. |
kwhetstone
reviewed
Jul 21, 2020
|
@sladyn98 looks like this needs to be rebased in order to be merged. Will rereview when this is rebased. |
|
I agree with Kristin. |
sladyn98
force-pushed
the
fix_docker_file
branch
from
bc6cd0f
to
b770c41
Compare
|
Rebased |
kwhetstone
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typo in frontend Dockerfile
Adds a dockerignore for the backend thus reducing the size