Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on config-file-provider explicitly (#280) #282

Merged

Conversation

strangelookingnerd
Copy link
Contributor

See #280

Testing done

None.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@strangelookingnerd strangelookingnerd enabled auto-merge (squash) January 8, 2024 12:45
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite
Copy link
Contributor

Could be labeled test so that it will be described in the changelog as a test change. Thanks again.

@strangelookingnerd strangelookingnerd self-assigned this Jan 8, 2024
@strangelookingnerd strangelookingnerd merged commit b3f7636 into main Jan 8, 2024
15 of 16 checks passed
@strangelookingnerd strangelookingnerd deleted the fix-tests-failing-in-plugin-bill-of-materials branch January 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom-folder-icon 2.11 fails tests in plugin bill of materials
2 participants