Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63197] Use cli properties only if they are defined #166

Closed
wants to merge 1 commit into from

Conversation

PierreBtz
Copy link
Contributor

Opening as a draft as I'd like to cover this part with additional tests.

I'm also unsure if the API is considered as stable in this project? In the current state of this PR I'm happily breaking it :)

@PierreBtz
Copy link
Contributor Author

After playing around a bit more I'm under the impression I initially missed something in that I should probably not invest any time in playing with BOM (JEP-309) as the format has been more or less dropped with the plugin installer using a different format and being the future of plugin management outside of a running Jenkins. Am I missing something?

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jul 27, 2020

After playing around a bit more I'm under the impression I initially missed something in that I should probably not invest any time in playing with BOM (JEP-309) as the format has been more or less dropped with the plugin installer using a different format and being the future of plugin management outside of a running Jenkins. Am I missing something?

You don't miss anything. After Jenkins Evergreen was abandoned, there is no real usages of the Jenkins BOM YAMLs in the production codebase. Personally I mostly switched to pom.xml inputs

@PierreBtz
Copy link
Contributor Author

Closing the PR for now, as the BOM future is not clear I won't be using it for now, so I won't finish fixing up the various issues with it in the CLI.

@PierreBtz PierreBtz closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants