[JENKINS-51214] - Allow invoking Custom WAR Packager Maven Plugin in the CLI Mode #26
Conversation
…the CLI Mode Also allows passing installArtifacts which is helpful in this mode
| if (batchMode) { | ||
| cfg.buildSettings.addMavenOption("--batch-mode"); | ||
| cfg.buildSettings.addMavenOption("-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"); | ||
| } |
There was a problem hiding this comment.
This is weird. Delete the option IMO.
There was a problem hiding this comment.
why is it weird?
It may be a bit hackish, but it works if a user does not pass proper settings.xml
There was a problem hiding this comment.
I think the calling script should be responsible for including -B among general Maven options. As to the log option, I consider this a workaround pending JENKINS-51182.
| @Parameter(property = "version") | ||
| public @CheckForNull String warVersion; | ||
|
|
||
| @Parameter(property = "tmpDir") |
There was a problem hiding this comment.
BTW if you add Javadoc for these things, and configure your POM to generate HelpMojo, you will make it easier for people to invoke this.
There was a problem hiding this comment.
For sure. Created https://issues.jenkins-ci.org/browse/JENKINS-51259
|
Added the options |
|
@jglick It is not a newly introduced thing in this commit, so I would prefer to keep it as is. Anyway, the documentation is pretty explicit that Maven settings is preferable. Later we can introduce the Maven settings option of course |
|
Will merge it as is and create a follow-up ticket |
Also allows passing installArtifacts which is helpful in this mode
Example:
@reviewbybees @raul-arabaolaza