[JENKINS-51302] - Properly cleanup Metadata so that PCT does not miss metadata for running integration tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metadata for running integration tests
|
It should help jenkinsci/remoting#265, but not 100% sure. Works locally at least |
jglick
reviewed
May 15, 2018
|
Let's see how it flies in prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change we will have 2 POMs in resources: one for "jenkins-war" and another one for the artifact ID defined in Custom WAR Packager settings. If CWP defines "org.jenkins-ci.main:jenkins-war", the pom.xml will be just overridden hence there is no compatibility issues with existing demos.
https://issues.jenkins-ci.org/browse/JENKINS-51302
@reviewbybees @raul-arabaolaza @jglick