Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alert styles #484

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Remove alert styles #484

merged 4 commits into from
Apr 10, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Apr 2, 2024

With jenkinsci/jenkins#9115 it's no longer necessary for themes to set alert style variables - so this merge request removes them.

Can either have the minimum Jenkins version be set to the weekly that contains the above MR or I can set the variables here with a comment that they can eventually be removed.

Before 9115
image

After 9115
image

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@janfaracik janfaracik requested a review from a team as a code owner April 2, 2024 21:40
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a screenshot, I think update the minimum version is best for maintenance.

@timja timja added the enhancement New feature or request label Apr 2, 2024
@janfaracik janfaracik changed the title WIP: Remove alert styles Remove alert styles Apr 10, 2024
@janfaracik
Copy link
Contributor Author

Updated it to point to the latest weekly with the relevant alert style changes.

@timja timja merged commit 3f988bc into jenkinsci:master Apr 10, 2024
15 checks passed
@janfaracik janfaracik deleted the reformat-alerts branch April 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants