JENKINS-24697 Add support for a validation query to prevent plugins getting a bad database handle returned #1
Conversation
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| <groupId>org.hibernate</groupId> | ||
| <artifactId>hibernate-validator</artifactId> | ||
| <version>4.1.0.Final</version> | ||
| </dependency> |
There was a problem hiding this comment.
Is there a reason that you are mixing versions? 3.x vs. 4.x?
There was a problem hiding this comment.
Something somewhere depended on ver 4.1 as a test dependency but I can't find it now Ill have another look at work tomorrow.
There was a problem hiding this comment.
hibernate-parent pom for 3.6.10.Final has
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
<version>4.1.0.Final</version>
</dependency>in dependencyManagement which is pulled in as a test dependency of hibernate-core
|
It would simplify the history if you could squash several commits to a single one... |
| @@ -3,7 +3,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>1.509</version><!-- which version of Jenkins is this plugin built against? --> | |||
| <version>1.565.2</version><!-- which version of Jenkins is this plugin built against? --> | |||
There was a problem hiding this comment.
please keep existed indents.
Also please replace this wrong <!-- which version of Jenkins is this plugin built against? --> message, with description of why this minimal core version is required.
|
Think I have squashed correctly but not sure first time I have done it |
|
Seems that there are still a lot of commits: https://github.com/jenkinsci/database-plugin/pull/1/commits Normally there should be only one remaining... |
|
And the help page still is missing... |
JENKINS-24697 Add support for a validation query to prevent plugins getting a bad database handle returned
|
Wouldn't it make sense to address all issues before merging? |
|
Woops thought I had but now I realize I forgot to push ;) |
|
@KostyaSha Got the wrong autocompletion for |
No description provided.