Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Windows images to AdoptOpenJDK + Add Git and Git LFS to Windows Images #113

Merged
merged 6 commits into from Mar 29, 2020
Merged

Switch Windows images to AdoptOpenJDK + Add Git and Git LFS to Windows Images #113

merged 6 commits into from Mar 29, 2020

Conversation

slide
Copy link
Member

@slide slide commented Mar 28, 2020

  • Use AdoptOpenJDK instead of plain OpenJDK
  • Fix issues with passwords expiring
  • Fix user creation issue
  • Add Git and Git LFS
  • Update versions
  • Add tests

@slide
Update Windows containers
90accca 
- Use AdoptOpenJDK instead of plain OpenJDK
- Fix issues with passwords expiring
- Fix user creation issue
- Add Git and Git LFS
- Update versions
- Add tests
@slide slide requested a review from a team as a code owner March 28, 2020 00:42
MarkEWaite
MarkEWaite approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I am unable to test it because I don't have access to necessary infrastructure. What have the results been during testing and how has it behaved?

@slide
Copy link
Member Author

slide commented Mar 28, 2020

It passes all the tests that the Linux container has. I am still working on bringing up a full local testing environment to test it. Do you have details on how you test things in your test environment?

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Mar 28, 2020 •
edited

Do you have details on how you test things in your test environment?

I'm not sure that my local environment will be any help. The public portion of my local environment is described in my lts-with-plugins branch. That includes docker_build.py to create the local images and docker_run.py to run the images.

The private portion of the local environment includes credentials and agents and jobs which require credentials and agents. Some of those agents have docker, but none of them are able to run Windows docker images (I'm not that modern yet).

@slide slide changed the title Update Windows containers [WIP] Update Windows containers Mar 28, 2020
@slide
Copy link
Member Author

slide commented Mar 28, 2020

Updated to WIP to do some more testing locally

@slide
Copy link
Member Author

slide commented Mar 28, 2020

I did some more extensive testing with some maven builds and so forth and things look good, so I am happy with this.

@MarkEWaite
Copy link
Contributor

That's great. Thanks so much! Approved to merge!

@slide slide changed the title [WIP] Update Windows containers Update Windows containers Mar 28, 2020
@slide slide merged commit 193324d into jenkinsci:master Mar 29, 2020
@slide slide deleted the windows-containers-updates branch March 29, 2020 01:29
@oleg-nenashev oleg-nenashev changed the title Update Windows containers Switch Windows images to AdoptOpenJDK + Add Git and Git LFS to Windows Images Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slide @MarkEWaite @oleg-nenashev