[WIP] Fix #134 - Add ltsc2019 and 1909 Windows images #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update nanoserver images to use AdoptOpenJDK method for getting JDK. - Update make.ps1 so that it will find all of the possible builds for windows automatically - Fix git lfs initialization on some images - # Conflicts: # 11/windows/windowsservercore-1809/Dockerfile # 8/windows/windowsservercore-1809/Dockerfile
- Add test for user account expiration
|
Bummer |
slide
changed the title
|
Moving this to WIP because we don't have the capability to build the images for ltsc2019 right now. |
|
Seems to only be the nanoserver-1909 image that fails to build now. |
olblak
reviewed
Oct 13, 2020
|
|
||
| VOLUME ${AGENT_ROOT}/.jenkins | ||
| VOLUME ${AGENT_WORKDIR} | ||
| WORKDIR ${AGENT_ROOT} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #134 adding ltsc2019 (windowsservercore) and 1909 (windowsservercore and nanoserver) images.
Also updated make.ps1 to search for dockerfiles within the directory structure so that it doesn't have to be updated when a new image is added.