Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use a multi-stage image for Windows Server Core #442

Merged
merged 2 commits into from Jul 1, 2023
Merged

feat: use a multi-stage image for Windows Server Core #442

merged 2 commits into from Jul 1, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 28, 2023 •
edited

This PR switches from an eclipse-temurin base image to a powershell:windowsservercore one, a multi-stage image like it's done for nanoserver.

Note: while all tests are passing, this can potentially be a breaking change.

Close #429

Testing done

https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-442/1/pipeline-console/?selected-node=28

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve marked this pull request as ready for review June 28, 2023 16:09
@lemeurherve lemeurherve requested a review from a team as a code owner June 28, 2023 16:09
@lemeurherve lemeurherve mentioned this pull request Jun 28, 2023
Merged
@lemeurherve lemeurherve mentioned this pull request Jun 28, 2023
Merged
@lemeurherve lemeurherve changed the title Avoid building Windows Server Core on top of eclipse-temurin image feat: use a multi-stage image for Windows Server Core Jun 28, 2023
dduportal
dduportal requested changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, ready to roll once my suggestion is taken in account

windows/windowsservercore-ltsc2019/Dockerfile Show resolved Hide resolved
@lemeurherve @dduportal
Update windows/windowsservercore-ltsc2019/Dockerfile
9f0b64a 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added enhancement breaking Breaking change windows and removed breaking Breaking change labels Jul 1, 2023
@dduportal dduportal merged commit 8fdc902 into jenkinsci:master Jul 1, 2023
4 checks passed
@lemeurherve lemeurherve deleted the patch-1 branch July 1, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Server Core: avoid building on top of eclipse-temurin image
3 participants
@lemeurherve @dduportal @timja