Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch JDK11, Alpine and Windows Dockerfiles to Remoting 3.35 #84

Merged
merged 1 commit into from Sep 24, 2019
Merged

Switch JDK11, Alpine and Windows Dockerfiles to Remoting 3.35 #84

merged 1 commit into from Sep 24, 2019

Conversation

alxsap
Copy link
Contributor

@alxsap alxsap commented Sep 23, 2019

@oleg-nenashev In #74 I missed to adjust the other Dockerfiles as well 😕
Sorry for that.

@alxsap
Copy link
Contributor Author

alxsap commented Sep 24, 2019

@oleg-nenashev @jeffret-b any thoughts on this? We (I) missed to update the other Dockerfiles with the new remoting version.

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I don't use docker agents much so I can't provide meaningful feedback on that part, but moving to the latest Remoting should be fine. It makes sense to upgrade to 3.35 to get the direction connection capabilities.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Sep 24, 2019 via email

@oleg-nenashev oleg-nenashev merged commit 0d4c3dc into jenkinsci:master Sep 24, 2019
@alxsap
Copy link
Contributor Author

alxsap commented Sep 25, 2019

@oleg-nenashev thanks. Enjoy your vacation 😊

@alxsap alxsap deleted the PR_remoting3.35 branch September 25, 2019 07:15
@alxsap
Copy link
Contributor Author

alxsap commented Sep 25, 2019

PS: who can release a new docker-slave version?

@slide
Copy link
Member

slide commented Sep 25, 2019

Once it's merged it should be auto built on dockerhub

@alxsap
Copy link
Contributor Author

alxsap commented Sep 25, 2019

Once it's merged it should be auto built on dockerhub

Ah, ok. Good to know.
But what I meant is a stable version like 3.35-3-alpine to reference in docker-jnlp-slave

@slide
Copy link
Member

slide commented Sep 25, 2019

I'm not sure how those tags get created.

@alxsap
Copy link
Contributor Author

alxsap commented Sep 26, 2019

I'm not sure how those tags get created.

@slide It seems Oleg switched to release-drafter 9 days ago. Before he created the tags manually.

I guess owners of the repo should see a new draft release?

As pull requests are merged, a draft release is kept up-to-date listing the changes, ready to publish when you’re ready

@oleg-nenashev oleg-nenashev changed the title Switch all Dockerfiles to remoting 3.35 Switch JDK11, Alpine and Windows Dockerfiles to Remoting 3.35 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants