Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Java 21 #146

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Test with Java 21 #146

merged 4 commits into from
Mar 28, 2024

Conversation

gounthar
Copy link
Contributor

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21.

Supersedes pull request: #143.
Supersedes pull request: #145.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

dependabot bot and others added 3 commits October 1, 2023 10:32
Bumps [io.jenkins.tools.bom:bom-2.387.x](https://github.com/jenkinsci/bom) from 2230.v0cb_4040cde55 to 2483.v3b_22f030990a_.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.387.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@gounthar gounthar requested a review from a team as a code owner October 12, 2023 16:09
@MarkEWaite
Copy link
Contributor

@dwnusbaum or @rsandell could you merge this so that the plugin is regularly tested with Java 21 and Java 17?

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with two optional changes. Approved whether or not those changes are made.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@basil basil merged commit 013ab9f into jenkinsci:master Mar 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants