Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

[JENKINS-61409] - Upgrade to Remoting version 4.3 for WebSocket large payload fix #153

Merged
merged 1 commit into from
Mar 30, 2020
Merged

[JENKINS-61409] - Upgrade to Remoting version 4.3 for WebSocket large payload fix #153

merged 1 commit into from
Mar 30, 2020

Conversation

jeffret-b
Copy link
Contributor

@jeffret-b jeffret-b requested a review from a team as a code owner March 26, 2020 15:22
@jeffret-b jeffret-b mentioned this pull request Mar 26, 2020
Merged
@slide
Copy link
Member

slide commented Mar 26, 2020

We need to wait for the docker-slave PR to land and a release of that container, correct?

@jeffret-b
Copy link
Contributor Author

I think so. We need to improve that process. It's difficult to keep it all going and make sure it all proceeds through.

@mbarbero
Copy link

docker-slave PR has been merged, could this one be merged as well?

@oleg-nenashev
Copy link
Member

A release for upstream is still needed. On it

@oleg-nenashev
Copy link
Member

https://github.com/jenkinsci/docker-slave/releases/tag/4.3-1 is out

@oleg-nenashev oleg-nenashev changed the title Upgrade to Remoting version 4.3 for WebSocket large payload fix [JENKINS-61409] - Upgrade to Remoting version 4.3 for WebSocket large payload fix Mar 30, 2020
oleg-nenashev
oleg-nenashev approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge/release once the CI passes

jglick
jglick approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analogous to #147. https://hub.docker.com/layers/jenkinsci/slave/4.3-1/images/sha256-39e6f883e6393d83edcf1c622aea1a84a1fe45e1e25cab8c54b8f570e7e94d0c?context=explore

@jglick
Copy link
Member

jglick commented Mar 30, 2020

Note to self: will also need a kubernetes plugin update, especially once the backport to LTS occurs.

@jglick
Copy link
Member

jglick commented Mar 30, 2020

a kubernetes plugin update

to amend jenkinsci/kubernetes-plugin#748

@slide
Copy link
Member

slide commented Mar 30, 2020

CI check done, merging.

@slide slide merged commit 8124425 into jenkinsci:master Mar 30, 2020
@jglick
Copy link
Member

jglick commented Mar 30, 2020

So should appear soon under: https://hub.docker.com/r/jenkinsci/jnlp-slave/tags

@jglick jglick mentioned this pull request Mar 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slide slide slide approved these changes

@jglick jglick jglick approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeffret-b @slide @mbarbero @oleg-nenashev @jglick