Bugfix: SSH retry count and wait config was being ignored (#677)

* SSH retry count and wait time correction
* unit test

.gitignore

@@ -6,3 +6,4 @@ work
 *~
 
 dependency-reduced-pom.xml
+.DS_Store

src/main/java/io/jenkins/docker/connector/DockerComputerSSHConnector.java

@@ -70,6 +70,8 @@ public class DockerComputerSSHConnector extends DockerComputerConnector {
     public DockerComputerSSHConnector(SSHKeyStrategy sshKeyStrategy) {
         this.sshKeyStrategy = sshKeyStrategy;
         this.port = 22;
+        this.maxNumRetries = 30;
+        this.retryWaitTime = 2;
     }
 
     public SSHKeyStrategy getSshKeyStrategy() {
@@ -225,10 +227,10 @@ protected ComputerLauncher createLauncher(DockerAPI api, String workdir, Inspect
         // TODO we could (also) have a more generic mechanism relying on healthcheck (inspect State.Health.Status)
         final PortUtils.ConnectionCheck connectionCheck =
                 PortUtils.connectionCheck( address )
-                        .withRetries( 30 )
-                        .withEveryRetryWaitFor( 2, TimeUnit.SECONDS );
+                        .withRetries( maxNumRetries )
+                        .withEveryRetryWaitFor( retryWaitTime, TimeUnit.SECONDS );
         if (!connectionCheck.execute() || !connectionCheck.useSSH().execute()) {
-            throw new IOException("SSH service didn't started after 60s.");
+            throw new IOException("SSH service didn't start after " + retryWaitTime*maxNumRetries + "s.");
         }
 
         return sshKeyStrategy.getSSHLauncher(address, this);

src/main/resources/io/jenkins/docker/connector/DockerComputerSSHConnector/help-maxNumRetries.html

@@ -0,0 +1 @@
+The number of attempts to connect to the newly-spun Docker container

src/main/resources/io/jenkins/docker/connector/DockerComputerSSHConnector/help-retryWaitTime.html

@@ -0,0 +1 @@
+Number of seconds to wait between attempts to connect to the newly-spun Docker container