[regression] Confusion between image and repository + ":" + tag

[guilhem]

There is some confusion in code between this docker notions.

Before 0.7, it was not a problem as we can set image to repo:tag like guilhem/vagrant-ubuntu:14.04.
But it's not possible anymore because (in particular) of this line: src/main/java/com/nirima/jenkins/plugins/docker/DockerCloud.java#L255 as it oblige tag latest (and fail if a : is given)

What we have to do is to add 2 new params, repository and tag.
If an image is given (a SHA) we can use it but can pull it.
If a repo + tag (by default "latest") is given, we can pull it if necessary.

I try coding it... it's over my java skills :(

[magnayn]

I'm not sure that's a regression; DockerCloud:255 is new for this version, it's spinning up a container if one hasn't been found (though, now that I look at it, I'm not sure it's in the right place).

However, what you say is also true - it shouldn't assume that 'latest' is the one that's wanted. It should use Identifier to figure out which part is which, so ought to be a relatively simple fix.

[guilhem]

Yes this is not exactly a regression, but it prevent from using a tag :) (who was working before).

[philpep]

+1 To have tags working again (either via container ID parsing or a separate param)

[magnayn]

I think you can work around if the slave already has the correct container..

[philpep]

It doesn't seem. See my issue #70 , the image wheezy64:jenkins exists on the docker server, but it try to start wheezy64:jenkins:latest

[samrocketman]

This appears to be fixed in docker plugin 0.8

[KostyaSha]

i have "asdfasdf:b25" and it spins "asdfasdf:b25", probably issue resolved.
Please try #210 and reopen if it still reproduces