JENKINS-45266: Support for setting shared memory size (--shm-size) for docker slaves #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laenzlinger
changed the title
laenzlinger
changed the title
|
it's now possible in KostyaSha/yet-another-docker-plugin 0.1.0-rc38 |
|
We have moved to yet-another-docker-plugin |
|
Is there any intention to merge this PR or the feature is a -1 ? |
|
I've looked through the changes and they seem ok to me. ...however the PR would need updating as the code has moved on since this PR was authored such that it won't merge as-is. |
|
Hi @laenzlinger could you retry to solve the merge request, some features in YADP like ssh login no well working. Thank you |
|
Rendered obsolete by #643. All further comments should be made there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our use case we would like to increase the shared memory size of the containers started by the docker-plugin. The setting is possible via the command line with the option --shm-size.
This PR allows to configure the shared memory sized in the jenkins plugin configuration (within the template config)