Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli) track version of git-lfs on Windows #276

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jul 10, 2023

This PR introduces an updatecli manifest to track the git-lfs versions (and open a Pull Request when a new versions is available).

Please note that the git-lfs tag and GitHub releases have a v prefix so the Dockerfiles are updated to take this in account

Testing done

  • Ran locally an updatecli diff --values ./updatecli/values.github-action.yaml --config ./updatecli/updatecli.d/git-lfs-windows.yml command which picked the latest v3.3.0 version instead of the current 3.1.4
  • Once merged, a new PR should be opened by updatecli to pick this new version (as a "real life test") with a passing set of checks

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review July 10, 2023 15:41
@dduportal dduportal requested a review from a team as a code owner July 10, 2023 15:41
updatecli/updatecli.d/git-lfs-windows.yml Outdated Show resolved Hide resolved
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
@dduportal dduportal merged commit 83ca0c5 into jenkinsci:master Jul 10, 2023
4 checks passed
@dduportal dduportal deleted the chore/updatecli/track-git-lfs branch July 10, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants