feat(windows): refactor docker-ssh-agent build process like docker-agent
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
docker-ssh-agent build process like docker-agentdocker-ssh-agent build process like docker-agent
lemeurherve
force-pushed
the
refactor-build-process
branch
6 times, most recently
from
1236481
to
b44ef39
Compare
Closed
lemeurherve
force-pushed
the
refactor-build-process
branch
from
79b11e8
to
66a22a4
Compare
lemeurherve
force-pushed
the
refactor-build-process
branch
from
d06c10a
to
d51f708
Compare
lemeurherve
changed the title
docker-ssh-agent build process like docker-agentdocker-ssh-agent build process like docker-agent
lemeurherve
force-pushed
the
refactor-build-process
branch
from
91738e8
to
15abf70
Compare
lemeurherve
force-pushed
the
refactor-build-process
branch
from
15abf70
to
4b74737
Compare
lemeurherve
changed the title
docker-ssh-agent build process like docker-agentdocker-ssh-agent build process like docker-agent
dduportal
approved these changes
Mar 25, 2024
This was referenced Mar 27, 2024
Closed
lemeurherve
added a commit
that referenced
this pull request
Apr 28, 2024
While working on #388 I remembered we disabled SSH specific tests for Windows Server Core image in order to deliver a new image cf notes of #289. This PR removes this skip and fix them by waiting 10s before trying to connect with SSH (5s wasn't enough), as discovered in #388 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the build process of Windows images, integrating all the improvements recently brought to https://github.com/jenkinsci/docker-agent.
This refactoring results in many modifications closing several issues:
eclipse-temurinimage #244ltsc2019images use1809base images instead ofltsc2019ones #288It will also allow to easily resolve in follow-up PRs:
And will facilitate:
git-lfsinstallation and bump of its version to 3.4.1 #318It applies the following to Windows images:
ARGvalues when factorized docker-agent#418 (docker compose file args weren't passed to Dockerfile during the build 🤔)Notes:
I'll work on them later as delivering a new release prevails the risk of having a borked Windows Server Core variant (IMO).
Testing done
https://ci.jenkins.io/job/Packaging/job/docker-ssh-agent/job/PR-289/69/
Submitter checklist