Use generally available JDK21 images #347

marvinruder · 2023-11-16T20:28:34Z

Create separate -preview configurations for architectures in early access
Fix early access URLs
Switch to Ubuntu 22.04 LTS build images
Fix make command in README.md

Resolves #346

Testing done

Submitter checklist

Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

* Create separate `-preview` configurations for architectures in early access * Fix early access URLs * Switch to Ubuntu 22.04 LTS build images * Fix `make` command in README.md Signed-off-by: Marvin A. Ruder <signed@mruder.dev>

marvinruder · 2023-11-16T20:33:39Z

Not sure if all my changes in the updatecli directory are as they should be, so please double-check there.

I was able to build and test all images successfully on arm64 architecture (including -preview images temporarily added to the configuration), but do not have access to other hardware, so a pipeline execution on your machines would be much appreciated.

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>

gounthar · 2023-11-16T21:03:25Z

Thank you so much for your contribution, @marvinruder . 🤗
I'll try a review tomorrow, but I guess others will start before I do. 😊

marvinruder · 2023-11-16T21:04:10Z

docker-bake.hcl

@@ -5,6 +5,7 @@ group "linux" {
    "alpine_jdk21",
    "debian_jdk11",
    "debian_jdk21",


Not sure if debian_jdk17 is missing here?

marvinruder · 2023-11-16T21:13:01Z

I also noticed that there is a debian_jdk11 base image available for linux/arm/v7, and debian_jdk17 base images available for linux/s390x and linux/arm/v7, but those combinations are not included in the Docker bake file. Is this intentional, are there other incompatibilities I am unaware of?

dduportal · 2023-11-17T08:40:34Z

Hi @marvinruder ! Thanks for this PR!

Not sure if all my changes in the updatecli directory are as they should be, so please double-check there.

No worries on the updatecli changes: the good practice is to focus on it on a subsequent PR so we'll check once this one is merged. Let's keep the current changes as they ensure we don't forget.

For the record, there are no execution errors in the CI (as per the GitHub Action check) for updatecli, which has 9 "pipelines" run, 5 are "success" (e.g. tracked dependencies are up-to-date) and 4 are "skipped" (new dependency detected but the condition are failing).

I was able to build and test all images successfully on arm64 architecture (including -preview images temporarily added to the configuration), but do not have access to other hardware, so a pipeline execution on your machines would be much appreciated.

Thanks for carefully checking! The pipeline checks are also all green which mean that the (build + test) on amd64 are all good and the "multi-architecture" was also a success.

For the record, we do not use specifi hardware for cross-platform container image build: as per

docker-ssh-agent/Jenkinsfile

Lines 78 to 82 in 0e5a76e

    
                                               sh ''' 
        
                                                   docker buildx create --use 
        
                                                   docker run --rm --privileged multiarch/qemu-user-static --reset -p yes 
        
                                                   docker buildx bake --file docker-bake.hcl linux 
        
                                               '''

we use qemu inside Docker along with buildx capabilities. it's a 3 line (and portable if you have Docker CE) script. No action expected i'm only adding this here so you know it is possible on your machine :)

I also noticed that there is a debian_jdk11 base image available for linux/arm/v7, and debian_jdk17 base images available for linux/s390x and linux/arm/v7, but those combinations are not included in the Docker bake file. Is this intentional, are there other incompatibilities I am unaware of?

Good catch, but that should be a topic for another PR if you don't mind. Having biug PRs with too much things impairs the ability to review and integrate feature efficiently: Let's start with the JDK21. I propose we or you open an issue to point the debian jdk11 stuff: I believe we should check that the default image switches to JDK17 as default in a subsequent PR (which would be a breaking change to be delivered after the JDK21 GA).

dduportal

Nice work, the image changes looks good, let's roll!

(we'll eventually 1 additional PR before triggering a release though)

Use generally available JDK21 images

194bbe1

* Create separate `-preview` configurations for architectures in early access * Fix early access URLs * Switch to Ubuntu 22.04 LTS build images * Fix `make` command in README.md Signed-off-by: Marvin A. Ruder <signed@mruder.dev>

marvinruder requested a review from a team as a code owner November 16, 2023 20:28

marvinruder added 3 commits November 16, 2023 21:45

Remove arm32 architecture from JDK21 configuration

3735115

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>

Remove setup for alpine_jdk21-preview

00a7206

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>

Remove alpine_jdk21-preview

5c6b816

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>

marvinruder commented Nov 16, 2023

View reviewed changes

dduportal approved these changes Nov 17, 2023

View reviewed changes

dduportal added enhancement alpine jdk21 debian labels Nov 17, 2023

dduportal merged commit 6aeeb51 into jenkinsci:master Nov 17, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use generally available JDK21 images #347

Use generally available JDK21 images #347

marvinruder commented Nov 16, 2023

Submitter checklist

marvinruder commented Nov 16, 2023

gounthar commented Nov 16, 2023

marvinruder Nov 16, 2023

marvinruder commented Nov 16, 2023

dduportal commented Nov 17, 2023

dduportal left a comment •

edited

Use generally available JDK21 images #347

Use generally available JDK21 images #347

Conversation

marvinruder commented Nov 16, 2023

Testing done

Submitter checklist

marvinruder commented Nov 16, 2023

gounthar commented Nov 16, 2023

marvinruder Nov 16, 2023

Choose a reason for hiding this comment

marvinruder commented Nov 16, 2023

dduportal commented Nov 17, 2023

dduportal left a comment • edited

Choose a reason for hiding this comment

dduportal left a comment •

edited