-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(updatecli) Re-enable JDK updates #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updatecli now wants us to get a more precise platform: `linux/amd64` instead of `amd/64`, `windows/amd64` instead of `amd64`, and so on.
Updatecli now wants us to get a more precise platform: `linux/amd64` instead of `amd/64`, `windows/amd64` instead of `amd64`, and so on.
On a side note, why don't we have
|
Because you removed it in #309 ^^ |
I think it should be restored (in a distinct PR). |
Ouch! |
5 tasks
dduportal
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run Summary
===========
Pipeline(s) run:
* Changed: 3
* Failed: 0
* Skipped: 0
* Succeeded: 6
* Total: 9
with:
- JDK21 upgrade:
path "variable.JAVA21_VERSION.default" updated from "21.0.1_12" to "21.0.2_13" in file "docker-bake.hcl"
- JDK17 upgrade:
path "variable.JAVA17_VERSION.default" updated from "17.0.8.1_1" to "17.0.10_7" in file "docker-bake.hcl"
- JDK11 upgrade:
path "variable.JAVA11_VERSION.default" updated from "11.0.20.1_1" to "11.0.22_7" in file "docker-bake.hcl"
dduportal
changed the title
feat(updatecli) Re-enable JDK updates
chore(updatecli) Re-enable JDK updates
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updatecli now requires us to specify a more precise platform:
linux/amd64
instead ofamd64
,windows/amd64
instead ofamd64
, and so forth.This change mirrors the adjustments made in this PR and serves as a precursor to #370.
Please note that I have reintroduced an
arm64
target in the checks for Alpine, as it is available.Although it was defined in the Docker bake file, it was never checked for in the updatecli manifest.
The JDK updates were delayed for some time because we had not yet transitioned to this new formalism.
This should fix it. 🤞
Testing done
Submitter checklist
Link to relevant issues in GitHub or Jira