Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Windows): add OpenSSH updatecli manifest #386

Merged

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Mar 27, 2024

This PR adds an updatecli manifest to track the version of https://github.com/PowerShell/Win32-OpenSSH

Testing done

Local test:
updatecli diff --config updatecli/updatecli.d/openssh.yml --values updatecli/values.github-action.yaml


+++++++++++
+ PREPARE +
+++++++++++

Loading Pipeline "updatecli/updatecli.d/openssh.yml"

SCM repository retrieved: 1


++++++++++++++++++
+ AUTO DISCOVERY +
++++++++++++++++++



++++++++++++
+ PIPELINE +
++++++++++++



#####################################
# BUMP `OPENSSH` VERSION ON WINDOWS #
#####################################


SOURCES
=======

lastVersion
-----------
Searching for version matching pattern "latest"
✔ GitHub release version "v9.5.0.0p1-Beta" found matching pattern "latest" of kind "latest"


CHANGELOG:
----------

Release published on the 2023-12-18 16:57:34 +0000 UTC at the url https://github.com/PowerShell/Win32-OpenSSH/releases/tag/v9.5.0.0p1-Beta

This is a beta-release (non-production ready)

This release includes:

- Upstream changes from [OpenSSH 9.5p1](https://www.openssh.com/txt/release-9.5) and a cherry-pick of the "strict KEX" protocol extension changes from [OpenSSH 9.6p1](https://www.openssh.com/txt/release-9.6).

- Breaking Changes:

    - Remove sha1-based MACs from default configuration options in https://github.com/PowerShell/openssh-portable/pull/706/files.

- Security Fixes: 
  - Service paths for SSHD and SSH-Agent in contrib\win32\openssh\install-sshd.ps1 are encapsulated in double-quotes.

- Non-Security Fixes:

  - [SCP/SFTP] Permit data upload that originates from a named pipe in https://github.com/PowerShell/openssh-portable/pull/704.  
  - Upgrade to LibreSSL 3.8.2. Please refer to https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-3.8.2-relnotes.txt.
  - Upgrade to LibFido2 1.14.0. Please refer to https://developers.yubico.com/libfido2/Release_Notes.html.



TARGETS
========

setGitLfsVersionWindowsNanoserver
---------------------------------

**Dry Run enabled**

⚠ The line #84, matched by the keyword "ARG" and the matcher "OPENSSH_VERSION", is changed from "ARG OPENSSH_VERSION=V8.6.0.0p1-Beta" to "ARG OPENSSH_VERSION=9.5.0.0p1-Beta".
⚠ - changed lines [84] of file "/var/folders/ly/77mv7l9968g068w9_fwzwggw0000gp/T/updatecli/github/jenkinsci/docker-ssh-agent/windows/nanoserver/Dockerfile"

setGitLfsVersionWindowsServer
-----------------------------

**Dry Run enabled**

⚠ The line #72, matched by the keyword "ARG" and the matcher "OPENSSH_VERSION", is changed from "ARG OPENSSH_VERSION=V8.6.0.0p1-Beta" to "ARG OPENSSH_VERSION=9.5.0.0p1-Beta".
⚠ - changed lines [72] of file "/var/folders/ly/77mv7l9968g068w9_fwzwggw0000gp/T/updatecli/github/jenkinsci/docker-ssh-agent/windows/windowsservercore/Dockerfile"


ACTIONS
========

[Dry Run] An action of kind "github/pullrequest" is expected.

=============================

REPORTS:



⚠ Bump `openssh` version on Windows:
        Source:
                ✔ [lastVersion] Get the latest `openssh` version
        Target:
                ⚠ [setGitLfsVersionWindowsNanoserver] Update the `openssh` Windows version for Windows Nanoserver
                ⚠ [setGitLfsVersionWindowsServer] Update the `openssh` Windows version for Windows Core Server


Run Summary
===========
Pipeline(s) run:
  * Changed:    1
  * Failed:     0
  * Skipped:    0
  * Succeeded:  0
  * Total:      1

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve changed the title chore(Windows): add OpenSSH updatecli manifest chore(Windows): add OpenSSH updatecli manifest Mar 27, 2024
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good (the checks output shows an OpenSSH incoming update if merged 👍 )

I have 2 blockers and 3 nitpicks though:

  • Target names to be changed (caught while searching the checks output and I was confused at first). Copy and paste ;)
  • OpenSSH name (instead of CLI-like formatting)

updatecli/updatecli.d/openssh.yml Outdated Show resolved Hide resolved
updatecli/updatecli.d/openssh.yml Outdated Show resolved Hide resolved
updatecli/updatecli.d/openssh.yml Outdated Show resolved Hide resolved
updatecli/updatecli.d/openssh.yml Outdated Show resolved Hide resolved
updatecli/updatecli.d/openssh.yml Outdated Show resolved Hide resolved
@lemeurherve lemeurherve enabled auto-merge (squash) March 29, 2024 07:46
@lemeurherve lemeurherve merged commit ff05308 into jenkinsci:master Mar 29, 2024
9 checks passed
@lemeurherve lemeurherve deleted the add-openssh-updatecli-manifest branch March 29, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants