-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Windows): add OpenSSH updatecli manifest #386
Merged
lemeurherve
merged 5 commits into
jenkinsci:master
from
lemeurherve:add-openssh-updatecli-manifest
Mar 29, 2024
Merged
chore(Windows): add OpenSSH updatecli manifest #386
lemeurherve
merged 5 commits into
jenkinsci:master
from
lemeurherve:add-openssh-updatecli-manifest
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
chore(Windows): add
chore(Windows): add OpenSSH updatecli manifest
Mar 27, 2024
OpenSSH
updatecli manifest
dduportal
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good (the checks output shows an OpenSSH incoming update if merged 👍 )
I have 2 blockers and 3 nitpicks though:
- Target names to be changed (caught while searching the checks output and I was confused at first). Copy and paste ;)
- OpenSSH name (instead of CLI-like formatting)
dduportal
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an updatecli manifest to track the version of https://github.com/PowerShell/Win32-OpenSSH
Testing done
Local test:
Submitter checklist