chore: improve Windows tests debug and small code cleanup

[lemeurherve]

This PR extracts tests debug improvement and small code cleanup from #388 and #295.

• We can now use -TestsDebug parameter or $env:TESTS_DEBUG to improve Windows tests debugging:
  • As it can be passed in the Jenkinsfile, it's easy now to activate it on a build replay instead of having to add a commit to switch debug on or off.
  • This parameter can take the following values:
    • empty/undefined: no additional debug (default value).
    • debug: output every test command and stderr on top of every test. (Equivalent of setting $quiet=$true in the test_helpers "Run-Program" function currently)
    • verbose: same as debug + output of stdout.
  • I tried using Powershell preference variables but didn't managed to get their values in the test_helpers functions without having to pass them around every call from ./build.ps1 to ./tests/sshAgent.ps1 to ./tests/test_helpers.ps1.
  • Using Run-Program in the beforeAll step of all tests involving SSH instead of calling docker directly so we can easily retrieve the commands used to reproduce them locally.
• Small code cleanup, mainly double quotes replacements by simple quotes, no functional change.
• Set build timeout from 30 to 60 minutes as builds take just about 30 minutes now.
• Added a section to the README explaining how to build and test Windows images locally.

Output:

With .\build.ps1 test -TestsDebug 'debug':

With .\build.ps1 test -TestsDebug 'verbose':

Testing done

Local tests + CI

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist Loading