New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set --user on exec, not on main run command #130
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
withCallback(new Callback(container, toolName)). | ||
start(); | ||
@Override | ||
public boolean start() throws Exception { | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems I made something wrong within my IDE without I noticed
@jglick updated, sorry for that |
I agree with this "I want the containers to start up as they were built, not with an arbitrary override" from the previous discussion #57 (comment) Here is very simple example without root which will fail on any of your jenkins instance: |
right, but on the other hand some images like the official dead end |
Is the debate at this point whether it is acceptable/possible at this point to make a breaking change to behavior, or which behavior is "more" right? |
We don't have any "correct" solution : both will bring issues with various images. From this point of view keeping the current behaviour without (more) breaking changes is the sole option I can consider. |
On solution could be to let -u uid:gid on run, which can be overrided by another -u uid2:gid2 in inside. |
Any ETA on when this may be addressed? |
I created an new PR with my solution explained above: #160 |
By my opinion, default behaviour of running docker images from jenkins pipeline must be the same, what you expect and what you get, when running same docker images on your local workspace. At least current situation must be documented and contain examples - because working around what's going on, when you can't reproduce workflow in pipeline take times! |
This is a reboot for #57 on a more recent codebase.