Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-51397] Pass environment to docker login command #140

Merged
merged 2 commits into from May 18, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented May 17, 2018

@jglick jglick requested review from abayer and ndeloof May 17, 2018 19:27
@jglick
Copy link
Member Author

jglick commented May 17, 2018

I should point out that I am not sure how to reproduce the reported bug manually, much less write an automated test for it (which would perhaps involve Docker-in-Docker, very problematic). I did run some experiments where I created a fake Docker installation which just printed its environment and arguments, and ran a representative program with this (a variant of the script I originally used to verify that the fix of JENKINS-38018 allowed me to log in to DockerHub). Before this patch, the environment was just that of the agent generally plus DOCKER_CONFIG; after the patch, it included environment variables specific to the build and step context, as it would be for example for a sh step at the same point.

@jglick jglick merged commit a19719c into jenkinsci:master May 18, 2018
@jglick jglick deleted the docker-login-env-JENKINS-51397 branch May 18, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants