Add ability to skip removal of container after docker stop via the org.jenkinsci.plugins.docker.workflow.client.DockerClient.SKIP_RM_ON_STOPproperty

[jonsten]

Added a system property which makes it possible to skip removal of containers after stop has been issued (either through container.stop() or during exit of within() step). This is useful for users (like us) which produces very large build trees in our containers, and in some situations, hit the timeout. Rather than extending the timeout we would like our builds to finish fast and then handle cleanup with separate janitor-job.

[jonsten]

Any idea when this will be merged and released?

[jglick]

Seems unwise to me. If you have issues at this scale, you are better off managing docker commands explicitly.

[jonsten]

Seems unwise to me. If you have issues at this scale, you are better off managing docker commands explicitly.

So you're telling me that if I use Jenkins in real-world large scale situations I shouldn't use high-level plugins like this one? That is quite worrying statement...

[oleg-nenashev]

Welcome to the open-source community. People sometimes have strong opinions there :)
Regarding the pull-request itself, I am perfectly fine with it. It does not alter the default behavior, so why not?

[oleg-nenashev]

P.S: Assigned to myself to get it delivered if no blocking reviews. ETA is after Feb 10 due to the business trips and other emergency tasks

[jonsten]

Friendly ping on this one, any chance to get it into master and released?

[jonsten]

@oleg-nenashev any news on this one?

[oleg-nenashev]

As you may guess, COVID destroyed my plans.... quite a lot. I am also not really available in the coming month (announcement). Since @car-roll has been active recently, maybe it would be the best to transfer this pull request.

Will also retrigger CI

[car-roll]

LGTM

[jerrywei116]

@oleg-nenashev Could you please give us an example about how to use "org.jenkinsci.plugins.docker.workflow.client.DockerClient.SKIP_RM_ON_STOP" in the jenkins pipeline job? Thanks.

[jonsten]

As the author I can pitch in here, org.jenkinsci.plugins.docker.workflow.client.DockerClient.SKIP_RM_ON_STOP is not intended to be used from individual Jenkins pipeline job. Instead, it governs the behaviour for all Jenkins pipeline jobs running on the controller. I.e. if you set -Dorg.jenkinsci.plugins.docker.workflow.client.DockerClient.SKIP_RM_ON_STOP=true when you start the Java process. Then all jenkins pipeline jobs will stopp removing the container when they terminate the container.