update to 2.176.4 #225
update to 2.176.4 #225
Conversation
| @@ -159,6 +159,12 @@ | |||
| <version>2.2</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>matrix-project</artifactId> | |||
There was a problem hiding this comment.
because of:
Caused by: java.io.IOException: Jenkins Git plugin version 4.2.2 failed to load. Matrix Project Plugin version 1.4.1 is older than required. To fix, install version 1.14 or later.
😞
There was a problem hiding this comment.
Well the BOM defines a version for matrix-project so perhaps you just need an explicit dependency, but without version?
There was a problem hiding this comment.
I would also add a comment here explaining why the dependency exists, something like this:
<!-- Required because git plugin optionally depends on a recent version of matrix-project, and if we do not depend on matrix-project here, an old version of matrix-project is installed automatically as a detached plugin, causing git plugin to fail to load. -->
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>matrix-project</artifactId> | ||
| <version>1.14</version> |
There was a problem hiding this comment.
so
| <version>1.14</version> |
| @@ -159,6 +159,12 @@ | |||
| <version>2.2</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>matrix-project</artifactId> | |||
There was a problem hiding this comment.
I would also add a comment here explaining why the dependency exists, something like this:
<!-- Required because git plugin optionally depends on a recent version of matrix-project, and if we do not depend on matrix-project here, an old version of matrix-project is installed automatically as a detached plugin, causing git plugin to fail to load. -->
| // TODO: Fails using Windows Git | ||
| DockerTestUtil.assumeNotWindows(); |
There was a problem hiding this comment.
nit: I'm not totally sure why DockerTestUtil.assumeNotWindows exists, but if you use assumeFalse directly you can have the message show up when the test is skipped (same goes for DockerBasicModelDefTest.failureBeforeStages, and if you want to make this change I think you'll need to add some imports manually):
| // TODO: Fails using Windows Git | |
| DockerTestUtil.assumeNotWindows(); | |
| assumeFalse("Fails using the version of Git installed on the Windows ACI agents on ci.jenkins.io", Functions.isWindows()); |
pom.xml
Outdated
| @@ -4,7 +4,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>3.40</version> | |||
| <version>3.57</version> | |||
There was a problem hiding this comment.
| <version>3.57</version> | |
| <version>4.6</version> |
updating jenkins version to 2.176.4, supersedes #214