Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Java versions for Windows with updatecli #1781

Merged
merged 4 commits into from Apr 22, 2024
Merged

Track Java versions for Windows with updatecli #1781

merged 4 commits into from Apr 22, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Nov 13, 2023 •
edited

This PR is a follow-up of #1770 to adapt updatecli manifests.

It also remove some unwanted conditions in JDK11 and JDK17 manifests looking for Nanoserver and Windows Server ltsc2022 images while they're not used in the build process.

There is more to be done as there seems to be yet another a specific versioning for last Temurin Windows releases, I'll use adoptium API, WIP.

Testing done

Ran updatecli on a fork of this repository.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve mentioned this pull request Nov 13, 2023
Merged
@MarkEWaite MarkEWaite self-assigned this Apr 22, 2024
@MarkEWaite MarkEWaite changed the title chore(updatecli): adapt jdk11 and jdk17 manifests for Windows Update Java versions Windows with updatecli Apr 22, 2024
@MarkEWaite MarkEWaite changed the title Update Java versions Windows with updatecli Track Java versions for Windows with updatecli Apr 22, 2024
@MarkEWaite MarkEWaite marked this pull request as ready for review April 22, 2024 18:46
@MarkEWaite MarkEWaite requested a review from a team as a code owner April 22, 2024 18:46
@MarkEWaite MarkEWaite merged commit ecfe905 into jenkinsci:master Apr 22, 2024
15 of 16 checks passed
@MarkEWaite
Copy link
Contributor

Merged after verifying expected results in the updatecli run

MarkEWaite
MarkEWaite reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after the fact.

@dduportal dduportal mentioned this pull request Apr 24, 2024
Merged
@lemeurherve lemeurherve deleted the fix-updatecli branch April 24, 2024 21:07
lemeurherve added a commit to lemeurherve/docker that referenced this pull request Apr 24, 2024
@lemeurherve @MarkEWaite
Track Java versions for Windows with updatecli (jenkinsci#1781)
0d9f797 
* chore(updatecli): adapt jdk11 and jdk17 manifests for Windows

* Fix spelling error in checkTemurinWindowsRelease

* Update Java 21 version in build-windows.yaml

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite left review comments

Assignees

@MarkEWaite MarkEWaite

Labels
chore jdk11 jdk17 updatecli windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lemeurherve @MarkEWaite