Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): remove ConvertFrom-Json issue by simplifying tags management #1841

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Mar 22, 2024

This PR fixes the same kind of issue as jenkinsci/docker-agent#780 also affecting this build by:

Testing done

CI build.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve changed the title fix(windows): remove \ConvertFrom-Json\ issue by simplifying tags management fix(windows): remove ConvertFrom-Json issue by simplifying tags management Mar 22, 2024
@lemeurherve lemeurherve marked this pull request as ready for review March 22, 2024 12:18
@lemeurherve lemeurherve requested a review from a team as a code owner March 22, 2024 12:18
@lemeurherve lemeurherve force-pushed the fix-windows-docker-compose-config-format-json branch from 84d05b0 to 30dc803 Compare March 22, 2024 12:19
@dduportal dduportal added the bug label Mar 22, 2024
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the publish part will only be tested for the 2.451 weekly release (26 March 2024).

Note 2: this change should make the publication process faster (cc @daniel-beck @MarkEWaite ) for the Windows container images 🥳

@dduportal dduportal merged commit 0b58775 into jenkinsci:master Mar 22, 2024
17 checks passed
@lemeurherve lemeurherve deleted the fix-windows-docker-compose-config-format-json branch March 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants