Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Windows): define tags in docker compose file instead of code #550

Merged
merged 5 commits into from Feb 10, 2024
Merged

chore(Windows): define tags in docker compose file instead of code #550

merged 5 commits into from Feb 10, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Oct 27, 2023 •
edited

This PR allows to define Windows images tags in docker compose file instead of relying on code in build.ps1 script, and to use the docker compose file for pushing the images and their tags.

Using docker compose like what has been done in jenkinsci/docker#1770 simplifies code logic and might improve publication time.

Changes without the cherry-picks of #547, #548 & #549 to review: c706390

Rebased from the primary branch to take #570 in account.

Testing done

  • Compared pwsh build.ps1 publish -DryRun outputs before and after
  • CI tests

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve changed the title feat(Windows): use docker-compose file for tags feat(Windows): use docker compose to publish images Nov 8, 2023
@lemeurherve lemeurherve changed the title feat(Windows): use docker compose to publish images feat(Windows): define tags in docker compose file instead of code Jan 13, 2024
@lemeurherve lemeurherve changed the title feat(Windows): define tags in docker compose file instead of code chore(Windows): define tags in docker compose file instead of code Jan 14, 2024
@lemeurherve lemeurherve marked this pull request as ready for review January 14, 2024 19:34
@lemeurherve lemeurherve requested a review from a team as a code owner January 14, 2024 19:34
@lemeurherve
Copy link
Member Author

Gentle ping @jenkinsci/team-docker-packaging

@lemeurherve lemeurherve merged commit 348b6f2 into jenkinsci:master Feb 10, 2024
10 checks passed
@lemeurherve lemeurherve deleted the feat-tags-in-docker-compose branch February 10, 2024 13:16
@lemeurherve lemeurherve mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lemeurherve @timja