Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alpine): Pin Alpine version to 3.18.0 #1653

Merged
merged 1 commit into from Jun 14, 2023

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Jun 14, 2023

In the hope of using dependabot to keep Alpine up to date, I'm proposing to fix first of all the Alpine version we use, as well as the Java 11 and 17 versions we use for Alpine.
I've already done the same for ssh-agent.

Testing done

docker buildx bake alpine_jdk11 --load

and

docker buildx bake alpine_jdk17 --load

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar marked this pull request as ready for review June 14, 2023 10:14
@gounthar gounthar requested a review from a team as a code owner June 14, 2023 10:14
@@ -77,6 +77,21 @@ variable "COMMIT_SHA" {
default = ""
}

variable "ALPINE_FULL_TAG" {
default = "3.18.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is dependabot able to update this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do hope so.

Copy link
Contributor

@dduportal dduportal Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested if you find a solution for doing this with Dependabot?
As per dependabot/feedback#154, it does not seem it is possible.

I understand the goal here would be to use updatecli as it's already working on the agent images?
Btw, I've opened updatecli/updatecli#1378

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the final goal for this PR, yes. 🤷
Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate should be able to do this as well without needing to add update cli:
https://docs.renovatebot.com/modules/manager/regex/

somewhat similar:
renovatebot/renovate#16439 (comment)

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dduportal dduportal merged commit 07dd84b into jenkinsci:master Jun 14, 2023
12 checks passed
@gounthar gounthar deleted the fixes-alpine-version branch June 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants