New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alpine): Pin Alpine version to 3.18.0 #1653
Conversation
@@ -77,6 +77,21 @@ variable "COMMIT_SHA" { | |||
default = "" | |||
} | |||
|
|||
variable "ALPINE_FULL_TAG" { | |||
default = "3.18.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is dependabot able to update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do hope so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested if you find a solution for doing this with Dependabot?
As per dependabot/feedback#154, it does not seem it is possible.
I understand the goal here would be to use updatecli
as it's already working on the agent images?
Btw, I've opened updatecli/updatecli#1378
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the final goal for this PR, yes. 🤷
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renovate should be able to do this as well without needing to add update cli:
https://docs.renovatebot.com/modules/manager/regex/
somewhat similar:
renovatebot/renovate#16439 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In the hope of using dependabot to keep Alpine up to date, I'm proposing to fix first of all the Alpine version we use, as well as the Java 11 and 17 versions we use for Alpine.
I've already done the same for
ssh-agent
.Testing done
and
Submitter checklist
Link to relevant issues in GitHub or JiraEnsure you have provided tests - that demonstrates feature works or fixes the issue