Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(debian): Pins Bullseye version for Debian #1657

Merged
merged 6 commits into from Jun 28, 2023

Conversation

gounthar
Copy link
Contributor

Following #1655, I added a BULLSEYE_TAG ARG in the Dockerfiles and in the Docker bake file for Debian (regular/slim)*(11/17).

Testing done

docker buildx bake debian_jdk17
docker buildx bake debian_jdk11
docker buildx bake debian_slim_jdk11 --load
docker buildx bake debian_slim_jdk17 --load

By the way, I had to comment out the platforms (except the linux/amd64) while testing because there is an issue when building for ppc64le on my machine. 馃し

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Just for your information, here is the faulty output for ppc64le when calling jlink. I remember I had that also on aarch64 a while back.

> [linux/ppc64le jre-build 2/2] RUN jlink   --add-modules ALL-MODULE-PATH   --no-man-pages   --compress=2   --output /javaruntime:
#0 0.452 Unknown privilege violation (03)
#0 0.452 NIP 000000401a5233b0   LR 0000004002bb6b00 CTR 000000401a523380 XER 0000000000000000 CPU#1
#0 0.452 MSR 9000000102806901 HID0 0000000000000000  HF 02806105 iidx 0 didx 0
#0 0.452 TB 00063048 270792036848270
#0 0.452 GPR00 ffffffbffcc26440 00000040033d99d0 0000004003022c00 00000040033dabc0
#0 0.452 GPR04 0000000000000000 0000000000002000 0000000000000000 0000000000000000
#0 0.452 GPR08 0000004003082c00 00000040030414fc 0000000000000001 0000000000000000
#0 0.452 GPR12 000000401a523380 00000040033e48f0 0000004001931410 0000000000000000
#0 0.452 GPR16 0000004001872000 000000401a5233a4 000000401a5233ac 000000401a5233d0
#0 0.452 GPR20 000000401a5233d8 0000004003054c28 00000040030414d8 00000000000003d8
#0 0.452 GPR24 0000004004026360 0000004004026738 00000040033d9a30 0000004004026350
#0 0.452 GPR28 0000004004025cb0 000000401a523380 0000004003083db0 00000040033d99d0
#0 0.452 CR 28884400  [ E  L  L  L  G  G  -  -  ]             RES 00000040033dabc0
#0 2.195 qemu: fatal: Tried to call a TRAP
#0 2.195
#0 2.195 NIP 000000401a528814   LR 0000004012ff5bcc CTR 000000401a578380 XER 0000000020040000 CPU#1
#0 2.195 MSR 9000000102806901 HID0 0000000000000000  HF 02806105 iidx 0 didx 0
#0 2.195 TB 00063049 270797121525385
#0 2.195 GPR00 0000000800000000 00000040033db8d0 0000004012ff5a00 000000058d056008
#0 2.195 GPR04 000000406a5324f8 0000000000000045 00000040033dba40 0000000000000006
#0 2.195 GPR08 000000406a18f780 000000406a18d538 000000058d00a140 0000000800077398
#0 2.195 GPR12 0000000800041bc8 00000040033e48f0 000000406a18f7c7 00000040033db998
#0 2.195 GPR16 0000004004025720 000000058d056008 00000040033dba80 00000040042530a0
#0 2.195 GPR20 000000401a52a038 00000040033db930 0000000000000024 ffffffff84000007
#0 2.195 GPR24 000000401a542f80 00000040030699a0 00000040033db9b8 000000406a192cc8
#0 2.195 GPR28 0000000000000000 0000004012fec000 00000000000000cb 000000406a18f8c8
#0 2.195 CR 28884442  [ E  L  L  L  G  G  G  E  ]             RES ffffffffffffffff
#0 2.195 FPR00 00000040041d7340 3ff013446d2e3188 3fc999999999999a 43d9d99960000000
#0 2.195 FPR04 6766656463626160 7776757473727170 8786858483828180 0000000000000000
#0 2.195 FPR08 0000000000000000 403a000000000000 0000000000000064 000000000000ea60
#0 2.195 FPR12 409b680000000000 0000000007ff0a70 0000000000000000 3fe8000000000000
#0 2.195 FPR16 0000000000000000 0000000000000000 0000000000000000 0000000000000000
#0 2.195 FPR20 0000000000000000 0000000000000000 0000000000000000 0000000000000000
#0 2.195 FPR24 0000000000000000 0000000000000000 0000000000000000 0000000000000000
#0 2.195 FPR28 0000000000000000 0000000000000000 0000000000000000 0000000000000000
#0 2.195 FPSCR 0000000092024000
#0 2.220 Aborted
------
WARNING: No output specified for debian_jdk17 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
Dockerfile:5
--------------------
  4 |
  5 | >>> RUN jlink \
  6 | >>>   --add-modules ALL-MODULE-PATH \
  7 | >>>   --no-man-pages \
  8 | >>>   --compress=2 \
  9 | >>>   --output /javaruntime
 10 |
--------------------
ERROR: failed to solve: process "/bin/sh -c jlink   --add-modules ALL-MODULE-PATH   --no-man-pages   --compress=2   --output /javaruntime" did not complete successfully: exit code: 134

@timja
Copy link
Member

timja commented Jun 15, 2023

Your qeumu is probably out of date. That looks like a bug I filed and they fixed eventually

@gounthar
Copy link
Contributor Author

Your qeumu is probably out of date. That looks like a bug I filed and they fixed eventually

Thank you Tim, I'm working with WSL2, and all my packages are up to date. 馃し
I guess I'll have to wait a little bit more until the fix makes its way into the official packages.

@dduportal
Copy link
Contributor

I have the same error on Docker Desktop on macOS: it's related to the embeded qemu.
To fix it, you can run this line: https://github.com/jenkinsci/docker/blob/439170b99f3b5841eced2be42057d67110f6afaa/Jenkinsfile#LL139C29-L139C99 (of course, it goes away as soon as you restart Docker, WSL or your machine)

@gounthar
Copy link
Contributor Author

Thank you Damien 馃 !
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes did the trick!

@gounthar gounthar marked this pull request as ready for review June 19, 2023 13:35
@gounthar gounthar requested review from ksalerno99 and a team as code owners June 19, 2023 13:35
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me so long as there is not too long a period until the merge of

Today the Debian versions are tracked by dependabot (as seen in #1651 and #1652). As far as I can tell, this will make it so that dependabot cannot track the Debian version.

I ran

BULLSEYE_TAG=20230522 JENKINS_VERSION=2.401.1 JENKINS_SHA=600b73eabf797852e39919541b84f7686ff601b97c77b44eb00843eb91c7dd6c make build-debian_slim_jdk11

and then checked that the older BULLSEYE_TAG value was used and that Jenkins 2.401.1 was placed in the container image.

@dduportal dduportal enabled auto-merge June 26, 2023 15:05
@dduportal dduportal disabled auto-merge June 28, 2023 13:12
@dduportal
Copy link
Contributor

The checks are ok for me: build + tests are ok.
The only checks error is due to a controller restart on ci.jenkins.io and is only about Windows tests.

LGTM!

@dduportal dduportal merged commit 3c143f2 into jenkinsci:master Jun 28, 2023
10 of 11 checks passed
@gounthar gounthar deleted the pins-bullseye-version branch June 28, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants